Add test for setting the external_id parameter #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewcarroll
commented
Sep 13, 2024
| }) | ||
| .reply(200, {}); | ||
|
|
||
| jobs.importUsers(Object.assign({}, data, { external_id })).then(() => { |
There was a problem hiding this comment.
Using Object.assign instead of spread here for style consistency with other tests in this file.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a test for setting the
external_idparameter when bulk importing users.The lcov report shows that the test added on this branch increased the Branches coverage from 93.75% to 100% for the file
src/management/__generated/managers/jobs-manager.ts.Screenshot of coverage on this branch:
Screenshot of coverage on master:
I'm happy to change or consolidate anything else in this file if you'd like.
Thank you!
References
Bulk importing users
Testing
Run
npm testto run the new test in this PR.Run
npm run test:cito generate the code coverage report for this branch, shown in the screenshot above.Checklist